Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for run now dialog #1349

Merged
merged 1 commit into from Nov 21, 2016
Merged

Fixes for run now dialog #1349

merged 1 commit into from Nov 21, 2016

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Nov 17, 2016

The dialog was not starting correctly in some cases. From the requests page it was not correctly grabbing the request id. From the request detail page, it is now getting an array of responses from a Promise.all, not a single response.

@ssalinas ssalinas modified the milestone: 0.13.0 Nov 18, 2016
@ssalinas ssalinas added the hs_stable label Nov 18, 2016
@ssalinas ssalinas merged commit 872fc1f into master Nov 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the run_now_dialog_fixes branch Nov 21, 2016
@ssalinas ssalinas removed hs_qa labels Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.