Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounce updates for placement and scaling #1360

merged 12 commits into from Dec 20, 2016

Bounce updates for placement and scaling #1360

merged 12 commits into from Dec 20, 2016


Copy link

@ssalinas ssalinas commented Dec 7, 2016

A few goals/changes in this PR:

  • At the end of an expiring scale, if a request has bounceAfterScale set to true, bounce the request
  • Configurably allow bounces to reuse hosts already running the task (for requests with SEPARATE placement). This would allow a new task from the bounce to run on the same host as an old task, but not the same host as another new task from the bounce. Accomplished this by adding the actionId to the pending task so it is more readily available when deciding placement.
  • Let the backend handle bounce after scale rather than the ui issuing two calls. The new bounce after scale on the backend will now not spin up extra instances. The request is saved, but instead of enqueuing a pending request with UPDATED, we add a BOUNCE one instead.

Needs a good bit of testing still, but should hopefully solve a number of the bounce-related woes we've seen

@ssalinas ssalinas modified the milestones: 0.13.0, 0.14.0 Dec 7, 2016
@ssalinas ssalinas merged commit a01459d into master Dec 20, 2016
2 checks passed
@ssalinas ssalinas deleted the bounce_updates branch Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant