Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read group from task data if present #1368

Merged
merged 1 commit into from Dec 15, 2016
Merged

Read group from task data if present #1368

merged 1 commit into from Dec 15, 2016

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Dec 13, 2016

For cases where a group has changed for a request, we were using the newer/current request group, even when looking at older tasks. This updates the S3 resource to use the group as set in the task history first if it is present, falling back to the current request-level settings if that is not found.

/cc @jonathanwgoodwin

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 13, 2016
@ssalinas ssalinas merged commit 52c7269 into master Dec 15, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the s3_task_group branch Dec 15, 2016
@ssalinas ssalinas removed hs_qa labels Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.