Merged
Conversation
Let tar proceed in parallel
aaylward
reviewed
Dec 14, 2016
|
|
||
| this.targetDirectory = targetDirectory; | ||
| this.s3Artifact = s3Artifact; | ||
| this.timeoutMillis = timeoutMillis; |
Contributor
Author
There was a problem hiding this comment.
The JSON serializer should make any null value an Optional.
Contributor
|
@wsorenson or @tpetr is this PR gtg to stable? |
Contributor
|
Should be good to merge to hs_stable |
Contributor
|
This has been working fine in hs_stable, going to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows tar to happen in parallels.