Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block on dl only #1371

Merged
merged 5 commits into from Jan 23, 2017
Merged

Block on dl only #1371

merged 5 commits into from Jan 23, 2017

Conversation

wsorenson
Copy link
Contributor

@wsorenson wsorenson commented Dec 13, 2016

Allows tar to happen in parallels.

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 13, 2016
Preconditions.checkNotNull(targetDirectory);
Preconditions.checkNotNull(s3Artifact);

this.targetDirectory = targetDirectory;
this.s3Artifact = s3Artifact;
this.timeoutMillis = timeoutMillis;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkNotNull?

Copy link
Contributor Author

@wsorenson wsorenson Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON serializer should make any null value an Optional.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh word 👍

@ssalinas
Copy link
Member

ssalinas commented Jan 13, 2017

@wsorenson or @tpetr is this PR gtg to stable?

@tpetr
Copy link
Contributor

tpetr commented Jan 13, 2017

Should be good to merge to hs_stable

@ssalinas
Copy link
Member

ssalinas commented Jan 23, 2017

This has been working fine in hs_stable, going to merge

@ssalinas ssalinas merged commit ad5f227 into master Jan 23, 2017
2 checks passed
@ssalinas ssalinas deleted the block_on_dl_only branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants