Skip to content

Block on dl only#1371

Merged
ssalinas merged 5 commits intomasterfrom
block_on_dl_only
Jan 23, 2017
Merged

Block on dl only#1371
ssalinas merged 5 commits intomasterfrom
block_on_dl_only

Conversation

@wsorenson
Copy link
Copy Markdown
Contributor

Allows tar to happen in parallels.

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 13, 2016

this.targetDirectory = targetDirectory;
this.s3Artifact = s3Artifact;
this.timeoutMillis = timeoutMillis;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkNotNull?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON serializer should make any null value an Optional.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh word 👍

@ssalinas
Copy link
Copy Markdown
Contributor

@wsorenson or @tpetr is this PR gtg to stable?

@tpetr
Copy link
Copy Markdown
Contributor

tpetr commented Jan 13, 2017

Should be good to merge to hs_stable

@ssalinas
Copy link
Copy Markdown
Contributor

This has been working fine in hs_stable, going to merge

@ssalinas ssalinas merged commit ad5f227 into master Jan 23, 2017
@ssalinas ssalinas deleted the block_on_dl_only branch January 23, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants