Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block on dl only #1371

Merged
merged 5 commits into from Jan 23, 2017
Merged

Block on dl only #1371

merged 5 commits into from Jan 23, 2017

Conversation

@wsorenson
Copy link
Contributor

wsorenson commented Dec 13, 2016

Allows tar to happen in parallels.

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 13, 2016
wsorenson added 3 commits Dec 13, 2016
@tpetr tpetr added the hs_staging label Dec 13, 2016
Preconditions.checkNotNull(targetDirectory);
Preconditions.checkNotNull(s3Artifact);

this.targetDirectory = targetDirectory;
this.s3Artifact = s3Artifact;
this.timeoutMillis = timeoutMillis;

This comment has been minimized.

Copy link
@aaylward

aaylward Dec 14, 2016

checkNotNull?

This comment has been minimized.

Copy link
@wsorenson

wsorenson Dec 14, 2016

Author Contributor

The JSON serializer should make any null value an Optional.

This comment has been minimized.

Copy link
@aaylward
@wsorenson wsorenson added the hs_qa label Dec 15, 2016
@ssalinas
Copy link
Member

ssalinas commented Jan 13, 2017

@wsorenson or @tpetr is this PR gtg to stable?

@tpetr
Copy link
Member

tpetr commented Jan 13, 2017

Should be good to merge to hs_stable

@ssalinas ssalinas added the hs_stable label Jan 18, 2017
@tpetr

This comment has been minimized.

Copy link
Member

tpetr commented on 44b9404 Jan 19, 2017

🚢

@ssalinas
Copy link
Member

ssalinas commented Jan 23, 2017

This has been working fine in hs_stable, going to merge

@ssalinas ssalinas merged commit ad5f227 into master Jan 23, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the block_on_dl_only branch Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.