Block on dl only #1371

Merged
merged 5 commits into from Jan 23, 2017

Conversation

Projects
None yet
4 participants
@wsorenson
Member

wsorenson commented Dec 13, 2016

Allows tar to happen in parallels.

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 13, 2016

wsorenson added some commits Dec 13, 2016

@tpetr tpetr added the hs_staging label Dec 13, 2016

Preconditions.checkNotNull(targetDirectory);
Preconditions.checkNotNull(s3Artifact);
this.targetDirectory = targetDirectory;
this.s3Artifact = s3Artifact;
+ this.timeoutMillis = timeoutMillis;

This comment has been minimized.

@aaylward

aaylward Dec 14, 2016

checkNotNull?

@aaylward

aaylward Dec 14, 2016

checkNotNull?

This comment has been minimized.

@wsorenson

wsorenson Dec 14, 2016

Member

The JSON serializer should make any null value an Optional.

@wsorenson

wsorenson Dec 14, 2016

Member

The JSON serializer should make any null value an Optional.

This comment has been minimized.

@aaylward

aaylward Dec 14, 2016

oh word 👍

@wsorenson wsorenson added the hs_qa label Dec 15, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jan 13, 2017

Member

@wsorenson or @tpetr is this PR gtg to stable?

Member

ssalinas commented Jan 13, 2017

@wsorenson or @tpetr is this PR gtg to stable?

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jan 13, 2017

Member

Should be good to merge to hs_stable

Member

tpetr commented Jan 13, 2017

Should be good to merge to hs_stable

@ssalinas ssalinas added the hs_stable label Jan 18, 2017

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jan 19, 2017

Member

🚢

Member

tpetr commented on 44b9404 Jan 19, 2017

🚢

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jan 23, 2017

Member

This has been working fine in hs_stable, going to merge

Member

ssalinas commented Jan 23, 2017

This has been working fine in hs_stable, going to merge

@ssalinas ssalinas merged commit ad5f227 into master Jan 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the block_on_dl_only branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment