New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec so shell commands read correct pid #1372

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Dec 13, 2016

Previously, when using maxOpenFiles the actual runnign process would end up being a child pid of the /bin/bash cmd. So any shell commands that rely on the pid were getting the parent pid, not the pid of the process.

The additional exec will fix this.

/cc @tpetr

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 14, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Dec 15, 2016

Member

🚢

Member

tpetr commented on aac02fc Dec 15, 2016

🚢

@ssalinas ssalinas added the hs_stable label Dec 15, 2016

@ssalinas ssalinas merged commit 126a1cf into master Dec 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the ulimit_executor branch Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment