New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request for 'deploy to unpause' before saving pending deploy #1376

Merged
merged 1 commit into from Jan 23, 2017

Conversation

Projects
None yet
1 participant
@ssalinas
Member

ssalinas commented Dec 14, 2016

There is a race condition where the SingularityDeployChecker can grab the new pending deploy and fail it due to the request still being in the PAUSED state, before the DeployResource has time to update the state.

Not certain this is the best fix, definitely open to suggestions here.

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 14, 2016

@ssalinas ssalinas changed the title from Update request for deploy to unpause before saving pending deploy to Update request for 'deploy to unpause' before saving pending deploy Dec 15, 2016

@ssalinas ssalinas added the hs_stable label Jan 13, 2017

@ssalinas ssalinas merged commit 529c7a9 into master Jan 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the deploy_race_fix branch Jan 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment