Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxTasksPerOffer at request level #1382

Merged
merged 4 commits into from Jan 3, 2017
Merged

Add maxTasksPerOffer at request level #1382

merged 4 commits into from Jan 3, 2017

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Dec 19, 2016

Allow a request to override the max tasks per offer so we can avoid scheduling a large stack of tasks on a single host
/cc @tpetr

@ssalinas ssalinas modified the milestone: 0.14.0 Dec 19, 2016
@tpetr
Copy link
Member

@tpetr tpetr commented Dec 20, 2016

Can we update SingularityValidator to ensure that maxTasksPerOffer is positive?

@ssalinas
Copy link
Member Author

@ssalinas ssalinas commented Dec 20, 2016

Good, point @tpetr , added to the validator

@ssalinas ssalinas added the hs_staging label Dec 20, 2016
@ssalinas
Copy link
Member Author

@ssalinas ssalinas commented Dec 20, 2016

FYI, added a global setting for the request-level limit as well

@ssalinas ssalinas added hs_qa labels Dec 20, 2016
@ssalinas ssalinas merged commit 2ab38a7 into master Jan 3, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the max_per_req branch Jan 3, 2017
@ssalinas ssalinas removed hs_qa labels Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.