New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No retry for scheduled tasks run on-demand through UI #1387

Merged
merged 4 commits into from Jan 13, 2017

Conversation

Projects
None yet
3 participants
@darcatron
Contributor

darcatron commented Dec 29, 2016

Changes:

  • UI initiated 'run now' won't retry
  • Failed tasks aren't included in average task runtime

@tpetr

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Dec 29, 2016

Member

LGTM, thanks! Could you add a unittest to verify this, merge into hs_staging, test, then merge into hs_qa?

Member

tpetr commented Dec 29, 2016

LGTM, thanks! Could you add a unittest to verify this, merge into hs_staging, test, then merge into hs_qa?

resourceOffers();
SingularityTask task = taskManager.getActiveTasks().get(0);
statusUpdate(task, TaskState.TASK_FAILED);
Assert.assertEquals(cmdLinArgs, taskManager.getPendingTasks().get(0).getCmdLineArgsList());

This comment has been minimized.

@darcatron

darcatron Dec 29, 2016

Contributor

@tpetr I should note that I changed this test since we no longer create a PendingTask as there is no more retrying

@darcatron

darcatron Dec 29, 2016

Contributor

@tpetr I should note that I changed this test since we no longer create a PendingTask as there is no more retrying

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 3, 2017

@ssalinas ssalinas changed the title from UI "Run Now" fixes to No retry for scheduled tasks run on-demand through UI Jan 3, 2017

@darcatron darcatron added the hs_stable label Jan 9, 2017

@darcatron darcatron merged commit b52f474 into master Jan 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@darcatron darcatron deleted the on-demand-retry branch Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment