Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally skip extra s3 metadata #1392

Merged
merged 2 commits into from Jan 6, 2017
Merged

Optionally skip extra s3 metadata #1392

merged 2 commits into from Jan 6, 2017

Conversation

@ssalinas
Copy link
Member

ssalinas commented Jan 6, 2017

No description provided.

@@ -199,7 +199,7 @@ private boolean isCurrentDeploy(String requestId, String deployId) {
return prefixes;
}

private List<SingularityS3Log> getS3LogsWithExecutorService(S3Configuration s3Configuration, Optional<String> group, ListeningExecutorService executorService, Collection<String> prefixes) throws InterruptedException, ExecutionException, TimeoutException {
private List<SingularityS3Log> getS3LogsWithExecutorService(S3Configuration s3Configuration, Optional<String> group, ListeningExecutorService executorService, Collection<String> prefixes, final boolean excldueMetadata) throws InterruptedException, ExecutionException, TimeoutException {

This comment has been minimized.

Copy link
@tpetr

tpetr Jan 6, 2017

Member

typo here

This comment has been minimized.

Copy link
@ssalinas

ssalinas Jan 6, 2017

Author Member

thanks, fixed

@tpetr
Copy link
Member

tpetr commented Jan 6, 2017

LGTM

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 6, 2017
@ssalinas ssalinas merged commit 80e9d0a into master Jan 6, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the skip_metadata branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.