Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shade com.google.thirdparty #1397

Merged
merged 1 commit into from Jan 18, 2017
Merged

Shade com.google.thirdparty #1397

merged 1 commit into from Jan 18, 2017

Conversation

@stevegutz
Copy link
Contributor

stevegutz commented Jan 12, 2017

Guava 16 introduced packages starting with com.google.thirdparty which need to be shaded as well. I am augmenting all current shadings of Guava regardless of version to prevent future issues.

@ssalinas @jhaber

@ssalinas ssalinas added the hs_staging label Jan 12, 2017
@ssalinas
Copy link
Member

ssalinas commented Jan 12, 2017

Thanks @stevegutz LGTM

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 18, 2017
@ssalinas ssalinas merged commit 939d550 into master Jan 18, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the shade-google-thirdparty branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.