Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications on S3ArtifactSignature #1398

Merged
merged 1 commit into from Jan 27, 2017
Merged

Conversation

ssalinas
Copy link
Member

We've mentioned that it was unclear exactly what this class was used for. In terms of field and method naming, things are accurate, when explained in context. I've added an ApiModel annotation giving a brief description of the class' purpose as well as slightly tweaking log statements to indicate that this is a file containing the signature for a separate artifact.

/cc @tpetr

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 18, 2017
@ssalinas ssalinas merged commit f837824 into master Jan 27, 2017
@ssalinas ssalinas deleted the s3_signature_clarification branch January 27, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants