Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications on S3ArtifactSignature #1398

Merged
merged 1 commit into from Jan 27, 2017
Merged

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jan 12, 2017

We've mentioned that it was unclear exactly what this class was used for. In terms of field and method naming, things are accurate, when explained in context. I've added an ApiModel annotation giving a brief description of the class' purpose as well as slightly tweaking log statements to indicate that this is a file containing the signature for a separate artifact.

/cc @tpetr

@ssalinas ssalinas added the hs_staging label Jan 13, 2017
@ssalinas ssalinas modified the milestone: 0.14.0 Jan 18, 2017
@ssalinas ssalinas added hs_qa labels Jan 23, 2017
@darcatron

This comment has been minimized.

Copy link
Contributor

@darcatron darcatron commented on ae4cfcf Jan 24, 2017

🚢

@ssalinas ssalinas merged commit f837824 into master Jan 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the s3_signature_clarification branch Jan 27, 2017
@ssalinas ssalinas removed hs_qa labels Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.