Ability to override docker workdir #1401

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jan 18, 2017

Previously the custom executor was always setting the workdir as the task app directory. This will allow the docker parameters to override that setting. It also cleans up the parameters rendering so that an arg like e gets written as -e not --e

@ssalinas ssalinas added the hs_staging label Jan 19, 2017

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 20, 2017

@ssalinas ssalinas added the hs_qa label Jan 20, 2017

Ability to override docker workdir
allow an empty command

fix toCmdLineArg format

also check if valus is null/empty when generating command line string
@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jan 23, 2017

Member

🚢

Member

tpetr commented on bc6f93d Jan 23, 2017

🚢

@ssalinas ssalinas added the hs_stable label Jan 23, 2017

@ssalinas ssalinas merged commit ad5e5dc into master Jan 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the docker_workdir branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment