Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to override docker workdir #1401

Merged
merged 1 commit into from Jan 27, 2017
Merged

Ability to override docker workdir #1401

merged 1 commit into from Jan 27, 2017

Conversation

@ssalinas
Copy link
Member

ssalinas commented Jan 18, 2017

Previously the custom executor was always setting the workdir as the task app directory. This will allow the docker parameters to override that setting. It also cleans up the parameters rendering so that an arg like e gets written as -e not --e

@ssalinas ssalinas force-pushed the docker_workdir branch from 86f4fe8 to 998839a Jan 19, 2017
@ssalinas ssalinas added the hs_staging label Jan 19, 2017
@ssalinas ssalinas force-pushed the docker_workdir branch from 998839a to 9a0a290 Jan 19, 2017
@ssalinas ssalinas modified the milestone: 0.14.0 Jan 20, 2017
@ssalinas ssalinas added the hs_qa label Jan 20, 2017
allow an empty command

fix toCmdLineArg format

also check if valus is null/empty when generating command line string
@ssalinas ssalinas force-pushed the docker_workdir branch from 9a0a290 to bc6f93d Jan 20, 2017
@tpetr

This comment has been minimized.

Copy link
Member

tpetr commented on bc6f93d Jan 23, 2017

🚢

@ssalinas ssalinas added the hs_stable label Jan 23, 2017
@ssalinas ssalinas merged commit ad5e5dc into master Jan 27, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the docker_workdir branch Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.