Conversation
ssalinas
force-pushed
the
docker_workdir
branch
from
86f4fe8 to
998839a
Compare
ssalinas
force-pushed
the
docker_workdir
branch
from
998839a to
9a0a290
Compare
allow an empty command fix toCmdLineArg format also check if valus is null/empty when generating command line string
ssalinas
force-pushed
the
docker_workdir
branch
from
9a0a290 to
bc6f93d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the custom executor was always setting the workdir as the task app directory. This will allow the docker parameters to override that setting. It also cleans up the parameters rendering so that an arg like
egets written as-enot--e