Repository navigation
introduce offer cache to allow better resource allocation - #1402
Conversation
|
|
||
| private void checkOut() { | ||
| LOG.trace("Checking out offer {}", offerId); | ||
| Preconditions.checkState(offerState == OfferState.AVAILABLE, "Offer %s was in state %s", offerId, offerState); |
There was a problem hiding this comment.
Saw a sentry come through for this the other day. This exception will bubble all the way back up to the LeaderOnlyPoller and cause us to abort. Should we maybe catch this and just skip the offer in the case that something else has it checked out?
|
|
||
| public void returnOffer(CachedOffer cachedOffer); | ||
|
|
||
| public List<Offer> peakOffers(); |
|
Fixed the merge conflicts and re-tested in each environment as well, going to merge this one 👍 |
|
@wsorenson how to disable this this feature? I could not find related info in http://getsingularity.com/Docs/reference/configuration.html. I think this feature eats all Mesos resources and then free some of them in 1 minute, and then again takes. So other frameworks could not run job fast. |
|
@miry It looks like the documentation needs to be updated, thanks for the heads up. You can disable offer caching by setting @ssalinas @wsorenson thoughts on having offer caching disabled by default? |
|
For the sake of those running in multi-framework clusters it might make sense to have it off by default. I can submit a PR with that and the documentation update |
5 participants
Currently, does not use cached offers.