Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some logging #1411

Merged
merged 2 commits into from Feb 10, 2017
Merged

Clean up some logging #1411

merged 2 commits into from Feb 10, 2017

Conversation

@ssalinas
Copy link
Member

ssalinas commented Feb 2, 2017

  • Strip the new lines and repeated spaces out of the toString for the mesos protos objects
  • Add shorter but helpful debug messages where we are now logging entire task objects

@wsorenson wasn't a quick-and-easy way to write a template to not log absent optionals in all the toString methods. But this should still clean things up a good bit. Will add to it a bit more tomorrow.

more logging updates
@ssalinas ssalinas force-pushed the logging_updates branch from edf25e8 to a2491f9 Feb 3, 2017
@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017
@ssalinas ssalinas added the hs_stable label Feb 10, 2017
@jonathanwgoodwin

This comment has been minimized.

Copy link
Member

jonathanwgoodwin commented on a2491f9 Feb 10, 2017

🚢

@jonathanwgoodwin

This comment has been minimized.

@ssalinas ssalinas merged commit 6d46258 into master Feb 10, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the logging_updates branch Feb 10, 2017
@ssalinas ssalinas removed hs_qa labels Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.