Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix duplicate exit checker, add longer initial task wait #1412
Conversation
wsorenson
added
the
hs_staging
label
Feb 3, 2017
wsorenson
added some commits
Feb 3, 2017
wsorenson
added
the
hs_qa
label
Feb 6, 2017
ssalinas
modified the milestone:
0.14.0
Feb 9, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
ssalinas
added
the
hs_stable
label
Feb 13, 2017
ssalinas
merged commit c9900f2
into
master
Feb 16, 2017
ssalinas
deleted the
executor_slow_launch
branch
Feb 16, 2017
ssalinas
removed
hs_qa
hs_stable
hs_staging
labels
Feb 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wsorenson commentedFeb 3, 2017
•
edited
Prevents an extra exit checker enrollment which will fail (and prevent normal shutdown)
Adds a new initial task wait that is longer than task wait.
Note that the executor already did the right thing WRT to locks/concurrency when the task is submitted after a shutdown has started, it was the extra exit checker enrollment which could cause a failure to propagate the TASK_LOST.