Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style of change display of overflow text #1414

Merged
merged 6 commits into from Feb 13, 2017
Merged

Conversation

@PtrTeixeira
Copy link
Contributor

PtrTeixeira commented Feb 6, 2017

Add a style to change the display of the overflow text. This will break
between words if possible, and if not possible will force a line wrap
when it hits the maximum with.

/cc @ssalinas

Add a style to change the display of the overflow text. This will break
between words if possible, and if not possible will force a line wrap
when it hits the maximum with.
@ssalinas
Copy link
Member

ssalinas commented Feb 6, 2017

will be nice to not have the command line args go off the screen anymore 💃

@ssalinas ssalinas added the hs_staging label Feb 6, 2017
@markhazlewood
Copy link

markhazlewood commented Feb 7, 2017

@PtrTeixeira Could we see an example of the new wrapping behavior? In general I'd recommend against having dropdown items take up multiple lines and instead use an ellipsis w/ tooltip overflow pattern. But would like to see this in context.

@PtrTeixeira
Copy link
Contributor Author

PtrTeixeira commented Feb 7, 2017

This is what I had part way through the working on this:
screen shot 2017-02-06 at 12 50 01 pm

I didn't think of using a tooltip to get the full content for the menu items. Will move over to that.

This prefers hiding the text with ellipsis and using a tooltip to
display the full content rather than wrapping text inside of dropdown
menu items. It uses the Bootstrap styled tooltips rather than system
native tooltips.
@ssalinas
Copy link
Member

ssalinas commented Feb 7, 2017

👍 thanks for the suggestion mark

Force the text in the tooltip onto a single line, which prevents the
line break from appearing from a different spot. Also remove the test
content that I had used instead of the actual content.  Oops.
@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017
@ssalinas
Copy link
Member

ssalinas commented Feb 9, 2017

@PtrTeixeira on staging right now it seems that additional arguments are not showing up in the history. A previous list of args with > 1 arg seems to only show the first one.

PtrTeixeira added 2 commits Feb 9, 2017
That is, if the arguments were of the form `['--arg1', '--arg2']`, then
`--arg1` and `--arg2` should not individually be broken, but also should
have a line to themselves.
@ssalinas ssalinas merged commit e5d1909 into master Feb 13, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the runnow-argument-overflow branch Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.