Add style of change display of overflow text #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a style to change the display of the overflow text. This will break between words if possible, and if not possible will force a line wrap when it hits the maximum with.
|
will be nice to not have the command line args go off the screen anymore 💃 |
|
@PtrTeixeira Could we see an example of the new wrapping behavior? In general I'd recommend against having dropdown items take up multiple lines and instead use an |
|
This is what I had part way through the working on this: I didn't think of using a tooltip to get the full content for the menu items. Will move over to that. |
This prefers hiding the text with ellipsis and using a tooltip to display the full content rather than wrapping text inside of dropdown menu items. It uses the Bootstrap styled tooltips rather than system native tooltips.
|
👍 thanks for the suggestion mark |
Force the text in the tooltip onto a single line, which prevents the line break from appearing from a different spot. Also remove the test content that I had used instead of the actual content. Oops.
|
@PtrTeixeira on staging right now it seems that additional arguments are not showing up in the history. A previous list of args with > 1 arg seems to only show the first one. |
That is, if the arguments were of the form `['--arg1', '--arg2']`, then `--arg1` and `--arg2` should not individually be broken, but also should have a line to themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a style to change the display of the overflow text. This will break
between words if possible, and if not possible will force a line wrap
when it hits the maximum with.
/cc @ssalinas