New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing global search with search from requests page #1415

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
@PtrTeixeira
Contributor

PtrTeixeira commented Feb 6, 2017

Change from directly using the fuzzy search API provided by fuzzy to
the existing custom one used in the search bar on the Requests page.
This did preserve using the existing react-typeahead element, rather
than switching to the react-select element. This should make the
global search a little less helter-skelter in what it matches.

One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.

/cc @ssalinas

Replace existing global search
Change from directly using the fuzzy search API provided by `fuzzy` to
the existing custom one used in the search bar on the Requests page.
This did preserve using the existing `react-typeahead` element, rather
than switching to the `react-select` element.

One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.
@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Feb 7, 2017

Contributor

Just a question. I saw that this updated search has a sub filter for task types ( SCHEDULED, ON_DEMAND, etc.). Will this be a possible global search query or is it part of the unused potential you mentioned?

Contributor

darcatron commented Feb 7, 2017

Just a question. I saw that this updated search has a sub filter for task types ( SCHEDULED, ON_DEMAND, etc.). Will this be a possible global search query or is it part of the unused potential you mentioned?

@PtrTeixeira

This comment has been minimized.

Show comment
Hide comment
@PtrTeixeira

PtrTeixeira Feb 7, 2017

Contributor

At the moment, it's unused; those filters are used on the requests page search, but not on the global search.

Contributor

PtrTeixeira commented Feb 7, 2017

At the moment, it's unused; those filters are used on the requests page search, but not on the global search.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 7, 2017

Member

@PtrTeixeira , The t search doesn't have the full range of state/type filters, I don't think we need to specify that field at all here. state: 'all' and the search input should be enough

Member

ssalinas commented Feb 7, 2017

@PtrTeixeira , The t search doesn't have the full range of state/type filters, I don't think we need to specify that field at all here. state: 'all' and the search input should be enough

@PtrTeixeira

This comment has been minimized.

Show comment
Hide comment
@PtrTeixeira

PtrTeixeira Feb 7, 2017

Contributor

filterSelector does a filter by the contents of subFilter against requestType; if subFilter is empty or undefined, it will remove everything from what it returns.

Contributor

PtrTeixeira commented Feb 7, 2017

filterSelector does a filter by the contents of subFilter against requestType; if subFilter is empty or undefined, it will remove everything from what it returns.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 7, 2017

Member

My mistake, I had thought that subFilter not present just skipped that filter. Let's give this a try in staging

Member

ssalinas commented Feb 7, 2017

My mistake, I had thought that subFilter not present just skipped that filter. Let's give this a try in staging

@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017

@ssalinas ssalinas added the hs_stable label Feb 13, 2017

@ssalinas ssalinas merged commit e5fa771 into master Feb 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the restrict-search-order branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment