Replace existing global search with search from requests page#1415
Replace existing global search with search from requests page#1415
Conversation
Change from directly using the fuzzy search API provided by `fuzzy` to the existing custom one used in the search bar on the Requests page. This did preserve using the existing `react-typeahead` element, rather than switching to the `react-select` element. One thing that we lost in this switchover: highlighting of matched characters. The search on the requests page doesn't use or emit that data, so it no longer comes into the global search. We also aren't as yet using the full potential of the global search - for example, you can't search by the deploy user, and you can't toggle searching by status.
|
Just a question. I saw that this updated search has a sub filter for task types ( SCHEDULED, ON_DEMAND, etc.). Will this be a possible global search query or is it part of the unused potential you mentioned? |
|
At the moment, it's unused; those filters are used on the requests page search, but not on the global search. |
|
@PtrTeixeira , The |
|
|
|
My mistake, I had thought that |
Change from directly using the fuzzy search API provided by
fuzzytothe existing custom one used in the search bar on the Requests page.
This did preserve using the existing
react-typeaheadelement, ratherthan switching to the
react-selectelement. This should make theglobal search a little less helter-skelter in what it matches.
One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.
/cc @ssalinas