New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify cache on mesos artifact #1417

Merged
merged 4 commits into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Feb 7, 2017

/fixes #1416

@ssalinas ssalinas referenced this pull request Feb 7, 2017

Closed

Artifacts cache #1416

@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017

@ssalinas ssalinas added the hs_staging label Feb 10, 2017

@ssalinas ssalinas merged commit db9b556 into master Feb 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the mesos_artifact branch Feb 15, 2017

@bydga

This comment has been minimized.

Show comment
Hide comment
@bydga

bydga Feb 23, 2017

Hi again, I've just tried the cache from self-compiled singularity (current master). And when I did a deployment with the original approach (no caching, just specifying the artifacts as strings)

uris: ["http://some.url/resource.tgz", "s3n://some-other-resource-from-s3.tgz"]

None of the resources was unpacked in the sandbox directory - which Mesos does by default when not specifying the cache field in the protobuf.

I think the behavior should be the same - see: http://mesos.apache.org/documentation/latest/fetcher/

message CommandInfo {
  message URI {
    required string value = 1;
    optional bool executable = 2;
    optional bool extract = 3 [default = true];
    optional bool cache = 4;
    optional string filename = 5;
  }
}

When I did the deploy with the object specification

uris: [{uri: "http://resource.tgz", extract: true} ]

everything worked just fine

bydga commented Feb 23, 2017

Hi again, I've just tried the cache from self-compiled singularity (current master). And when I did a deployment with the original approach (no caching, just specifying the artifacts as strings)

uris: ["http://some.url/resource.tgz", "s3n://some-other-resource-from-s3.tgz"]

None of the resources was unpacked in the sandbox directory - which Mesos does by default when not specifying the cache field in the protobuf.

I think the behavior should be the same - see: http://mesos.apache.org/documentation/latest/fetcher/

message CommandInfo {
  message URI {
    required string value = 1;
    optional bool executable = 2;
    optional bool extract = 3 [default = true];
    optional bool cache = 4;
    optional string filename = 5;
  }
}

When I did the deploy with the object specification

uris: [{uri: "http://resource.tgz", extract: true} ]

everything worked just fine

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 24, 2017

Member

Ah, I had been defaulting it to false for all of those parameters, we can update that

Member

ssalinas commented Feb 24, 2017

Ah, I had been defaulting it to false for all of those parameters, we can update that

@bydga

This comment has been minimized.

Show comment
Hide comment
@bydga

bydga Feb 27, 2017

Well, since you are breaking previous behaviour - which might cause all tasks that rely on an archive unpacking to fail, plus its against the mesos-default behavior, I would suggest to change the extract flag to true :)

bydga commented Feb 27, 2017

Well, since you are breaking previous behaviour - which might cause all tasks that rely on an archive unpacking to fail, plus its against the mesos-default behavior, I would suggest to change the extract flag to true :)

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 27, 2017

Member

Yep, like I said, we can update. I'll get a PR in before we do the next release

Member

ssalinas commented Feb 27, 2017

Yep, like I said, we can update. I'll get a PR in before we do the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment