Skip to content

Ability to specify cache on mesos artifact#1417

Merged
ssalinas merged 4 commits into
masterfrom
mesos_artifact
Feb 15, 2017
Merged

Ability to specify cache on mesos artifact#1417
ssalinas merged 4 commits into
masterfrom
mesos_artifact

Conversation

@ssalinas

@ssalinas ssalinas commented Feb 7, 2017

Copy link
Copy Markdown
Contributor

/fixes #1416

@ssalinas ssalinas mentioned this pull request Feb 7, 2017
@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017
@ssalinas ssalinas merged commit db9b556 into master Feb 15, 2017
@ssalinas ssalinas deleted the mesos_artifact branch February 15, 2017 14:59
@bydga

bydga commented Feb 23, 2017

Copy link
Copy Markdown

Hi again, I've just tried the cache from self-compiled singularity (current master). And when I did a deployment with the original approach (no caching, just specifying the artifacts as strings)

uris: ["http://some.url/resource.tgz", "s3n://some-other-resource-from-s3.tgz"]

None of the resources was unpacked in the sandbox directory - which Mesos does by default when not specifying the cache field in the protobuf.

I think the behavior should be the same - see: http://mesos.apache.org/documentation/latest/fetcher/

message CommandInfo {
  message URI {
    required string value = 1;
    optional bool executable = 2;
    optional bool extract = 3 [default = true];
    optional bool cache = 4;
    optional string filename = 5;
  }
}

When I did the deploy with the object specification

uris: [{uri: "http://resource.tgz", extract: true} ]

everything worked just fine

@ssalinas

Copy link
Copy Markdown
Contributor Author

Ah, I had been defaulting it to false for all of those parameters, we can update that

@bydga

bydga commented Feb 27, 2017

Copy link
Copy Markdown

Well, since you are breaking previous behaviour - which might cause all tasks that rely on an archive unpacking to fail, plus its against the mesos-default behavior, I would suggest to change the extract flag to true :)

@ssalinas

Copy link
Copy Markdown
Contributor Author

Yep, like I said, we can update. I'll get a PR in before we do the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifacts cache

2 participants