Update docker parameters on deploy form #1423

Merged
merged 2 commits into from Feb 13, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Feb 10, 2017

/fixes #1420

/cc @billwright

@@ -377,6 +385,14 @@ class NewDeployForm extends Component {
DOCKER_PORT_MAPPING_FIELDS,
(id) => portMapping[id] || INDEXED_DOCKER_PORT_MAPPING_FIELDS[id].default));
deployObject[fieldId.id] = portMappings;
+ } else if (fieldId.type === 'dockerParameters') {
+ console.log(fieldId)
+ debugger

This comment has been minimized.

@billwright

billwright Feb 10, 2017

What's this line do? debugger?
Ignore if this is obvious to JS programmers. New language for me.

@billwright

billwright Feb 10, 2017

What's this line do? debugger?
Ignore if this is obvious to JS programmers. New language for me.

This comment has been minimized.

@ssalinas

ssalinas Feb 10, 2017

Member

still testing stuff, going to remove all the logging and such

@ssalinas

ssalinas Feb 10, 2017

Member

still testing stuff, going to remove all the logging and such

@ssalinas ssalinas modified the milestone: 0.14.0 Feb 10, 2017

@ssalinas ssalinas added the hs_stable label Feb 13, 2017

@ssalinas ssalinas merged commit e7cee37 into master Feb 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the fix_deploy_form branch Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment