Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker parameters on deploy form #1423

Merged
merged 2 commits into from Feb 13, 2017
Merged

Update docker parameters on deploy form #1423

merged 2 commits into from Feb 13, 2017

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 10, 2017

/fixes #1420

/cc @billwright

@@ -377,6 +385,14 @@ class NewDeployForm extends Component {
DOCKER_PORT_MAPPING_FIELDS,
(id) => portMapping[id] || INDEXED_DOCKER_PORT_MAPPING_FIELDS[id].default));
deployObject[fieldId.id] = portMappings;
} else if (fieldId.type === 'dockerParameters') {
console.log(fieldId)
debugger

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this line do? debugger?
Ignore if this is obvious to JS programmers. New language for me.

Copy link
Member Author

@ssalinas ssalinas Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still testing stuff, going to remove all the logging and such

@ssalinas ssalinas modified the milestone: 0.14.0 Feb 10, 2017
@ssalinas ssalinas merged commit e7cee37 into master Feb 13, 2017
2 checks passed
@ssalinas ssalinas deleted the fix_deploy_form branch Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants