Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metric for immediate uploaders #1424

Merged
merged 1 commit into from Feb 15, 2017

Conversation

@PtrTeixeira
Copy link
Contributor

PtrTeixeira commented Feb 14, 2017

Rename the metric for immediate uploaders. I think that if you ask the MetricsRegistry for another counter with the same name, it will just give you back a reference to the original counter.

@ssalinas
Copy link
Member

ssalinas commented Feb 14, 2017

Good catch @PtrTeixeira LGTM

@ssalinas
Copy link
Member

ssalinas commented Feb 15, 2017

Looks fine in qa, let's move this to stable and merge it into the other PR branch @PtrTeixeira

@PtrTeixeira PtrTeixeira merged commit ad679c0 into s3uploader-upload-immediately Feb 15, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssalinas ssalinas modified the milestone: 0.14.0 Mar 13, 2017
@ssalinas ssalinas deleted the rename-metric branch Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.