Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly roll back from an overdue incremental deploy #1433

Merged
merged 1 commit into from Feb 28, 2017

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 25, 2017

After most failed or cancelled incremental deploys, we re-enqueue a pending request to be sure that all instances from the previous deploy are present. In the overdue case we weren't previously hitting this code block, so these would not always roll back to the correct instance count if we were part way through an incremental deploy when the deploy became overdue.

/cc @darcatron

@ssalinas ssalinas merged commit 547981a into master Feb 28, 2017
2 checks passed
@ssalinas ssalinas deleted the overdue_cleanup branch Feb 28, 2017
@ssalinas ssalinas modified the milestone: 0.14.0 Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant