Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Defer loading log files till after page load #1437
Move the action of loading the log files from S3 from
Move the action of loading the log files from S3 from `refresh`, where the `rootComponent` blocks page load until the Promise resolves, to `componentDidMount`, where it doesn't block page load. This is intended as a temporary fix, rather than a best-practice course of action.
Adds another hook for `rootComponent` to interact with the component lifecycle. In particular, the `onLoad` function provides a hook that will run during `componentDidMount`, in contrast to `refresh`, which provides a hook into `componentWillMount`. The intended use case is for kicking off actions which should be handled eventually, but which should not prevent the page from loading. The issue with doing those in `refresh` is that `rootComponent` will display a spinner until the promise returned from `refresh` is entirely complete; there isn't a mechanism for only having some requests block.