Ignore 404s for /priority/freeze endpoint#1443
Merged
Merged
Conversation
That endpoint returns 404s as part of its standard behavior. It isn't in this case a user-facing error message.
Contributor
|
+1 for updating prop types and code styles along the way, 🚢 |
Add a button and corresponding modal dialog to adjust the properties of a priority freeze. Actually, what it does is submits a new priority freeze that overwrites the existing one, but that's life. This also fixes an bug in the implementation of the remove priority freeze action; namely, the 'get priority freeze endpoint' returns an error (well, a 404) when there is no existing priority freeze. In general, this doesn't matter, but because the reducer treats it as an error rather than empty response that part of the state isn't refreshed. So removing a priority freeze wouldn't update the page to remove the active-priority-freeze box without refreshing the page. This adds an action+reducer to clear that part of the page before submitting the request to deal with that issues.
I realized immediately after I had written my own custom clear-this-field-in-the-state action+reducer that there was one that came with the `buildApiAction` work. Derp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That endpoint returns 404s as part of its standard behavior. It isn't in
this case a user-facing error message.