Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore 404s for /priority/freeze endpoint #1443

Merged
merged 5 commits into from Mar 20, 2017
Merged

Ignore 404s for /priority/freeze endpoint #1443

merged 5 commits into from Mar 20, 2017

Conversation

@PtrTeixeira
Copy link
Contributor

@PtrTeixeira PtrTeixeira commented Mar 6, 2017

That endpoint returns 404s as part of its standard behavior. It isn't in
this case a user-facing error message.

That endpoint returns 404s as part of its standard behavior. It isn't in
this case a user-facing error message.
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 6, 2017

+1 for updating prop types and code styles along the way, 🚢

Loading

PtrTeixeira added 2 commits Mar 10, 2017
Add a button and corresponding modal dialog to adjust the properties of
a priority freeze. Actually, what it does is submits a new priority
freeze that overwrites the existing one, but that's life.

This also fixes an bug in the implementation of the remove priority
freeze action; namely, the 'get priority freeze endpoint' returns an
error (well, a 404) when there is no existing priority freeze. In
general, this doesn't matter, but because the reducer treats it as an
error rather than empty response that part of the state isn't refreshed.
So removing a priority freeze wouldn't update the page to remove the
active-priority-freeze box without refreshing the page. This adds an
action+reducer to clear that part of the page before submitting the
request to deal with that issues.
I realized immediately after I had written my own custom
clear-this-field-in-the-state action+reducer that there was one that
came with the `buildApiAction` work. Derp.
@ssalinas ssalinas added this to the 0.15.0 milestone Mar 13, 2017
@ssalinas ssalinas added this to the 0.15.0 milestone Mar 13, 2017
@ssalinas ssalinas merged commit bc8d7a3 into tailer Mar 20, 2017
2 checks passed
Loading
@ssalinas ssalinas deleted the priority-freeze-404 branch Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants