Add a task credit system #1452
Merged
Add a task credit system #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disappointed you didn't call it Mesos Bucks. |
|
reworked to not use the proxy-to-leader piece |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a task credit system for disaster-type scenarios. By default the task credits are set to
-1(i.e. feature is not enabled). If you give Singularity credits, the feature is now enabled and the credits are decremented each time a task is launched. If the credits reach zero, no more tasks can be launched until more credits are given, or task credits are disabled (sets it back to-1)Currently this is all done in memory for speed, rather than frequently calling out to zk for something in the disasters nodes. So, all calls that do not hit the leader are proxied to the leader.
Also, fixed a few args to rootComponent that seemed to be off after the addition of the onLoad functionality (/cc @PtrTeixeira )