Don't allow multiple bounces for the same request #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we have validation that catches attempting to enqueue a bounce when 1 is already running. Not sure if something got removed over time here, but it no longer does that. Incremental bounce partially relies on the number of tasks in an INCREMENTAL_BOUNCE cleanup state. So, if a second bounce is enqueued, more tasks than expected are in this state, and things can be wrongly removed form the loadBalancer.
This adds a marker for when a request is bouncing so that multiple cannot be enqueued at once.