Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow multiple bounces for the same request #1457

Merged
merged 1 commit into from Mar 17, 2017
Merged

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 15, 2017

Normally we have validation that catches attempting to enqueue a bounce when 1 is already running. Not sure if something got removed over time here, but it no longer does that. Incremental bounce partially relies on the number of tasks in an INCREMENTAL_BOUNCE cleanup state. So, if a second bounce is enqueued, more tasks than expected are in this state, and things can be wrongly removed form the loadBalancer.

This adds a marker for when a request is bouncing so that multiple cannot be enqueued at once.

@ssalinas ssalinas merged commit 1ffc094 into master Mar 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@ssalinas ssalinas deleted the bounce_conflict branch Mar 17, 2017
@ssalinas ssalinas removed hs_qa labels Mar 17, 2017
@ssalinas ssalinas modified the milestone: 0.14.1 Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.