Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interchange argument order in rootComponent #1461

Merged
merged 1 commit into from Mar 17, 2017
Merged

Interchange argument order in rootComponent #1461

merged 1 commit into from Mar 17, 2017

Conversation

@PtrTeixeira
Copy link
Contributor

@PtrTeixeira PtrTeixeira commented Mar 17, 2017

Somehow, in the muddle of branches that is Git, this slipped through
onto master. Interchanges the order of arguments to rootComponent so
that onLoad is at the end, and fix the only caller that uses onLoad
to have it in the correct position.

Somehow, in the muddle of branches that is Git, this slipped through
onto `master`. Interchanges the order of arguments to `rootComponent` so
that `onLoad` is at the end, and fix the only caller that uses `onLoad`
to have it in the correct position.
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 17, 2017

We should double check this before/after tailer branch. The merge with that messed up a number of things for this

@ssalinas ssalinas added hs_qa labels Mar 17, 2017
@ssalinas ssalinas modified the milestone: 0.14.1 Mar 17, 2017
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 17, 2017

Thanks @PtrTeixeira , will get this in 0.14.1

@ssalinas ssalinas merged commit 8d74d0d into master Mar 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@ssalinas ssalinas deleted the onLoad-bug branch Mar 17, 2017
@ssalinas ssalinas removed hs_qa labels Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.