Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass job user as environment variable to task #1465
Merged
Conversation
SingularityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosTaskBuilder.java
Outdated
| @@ -184,6 +184,8 @@ private void prepareEnvironment(final SingularityTaskRequest task, SingularityTa | |||
| setEnv(envBldr, "TASK_ID", taskId.getId()); | |||
| setEnv(envBldr, "ESTIMATED_INSTANCE_COUNT", task.getRequest().getInstancesSafe()); | |||
|
|
|||
| setEnv(envBldr, "JOB_USER", task.getPendingTask().getUser().or("")); | |||
This comment has been minimized.
This comment has been minimized.
ssalinas
Mar 20, 2017
Member
Two things.
- Wondering if
JOB_USERis descriptive enough here. This method will get called for services and workers as well. Maybe something more likeSTARTED_BY_USER? - In the case where
useris not present on the pending task, would it make more sent to leave this out rather than have an empty string as the value?
Two small changes: * Change the name of the environment variable to something more descriptive (`JOB_USER` -> `STARTED_BY_USER`) * Don't set the environment variable at all if the user can't be found.
|
|
...rityService/src/test/java/com/hubspot/singularity/mesos/SingularityMesosTaskBuilderTest.java
Outdated
| success = success || (environmentVariable.getName().equals("STARTED_BY_USER") && environmentVariable.getValue().equals(user)); | ||
| } | ||
|
|
||
| assertTrue("Expected env variable JOB_USER to be set to " + user, success); |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PtrTeixeira commentedMar 20, 2017
•
edited
Pass the user who clicks the "Run Now" button as the value of the
environment variable
STARTED_BY_USERin the task environment. Can providemore granular, task-level permissions or auditability.