Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task direct link to logs #1467

Merged
merged 3 commits into from Mar 23, 2017
Merged

fix task direct link to logs #1467

merged 3 commits into from Mar 23, 2017

Conversation

@darcatron
Copy link
Contributor

@darcatron darcatron commented Mar 21, 2017

think this is the only usage. tested locally. worked fine
@ssalinas

@@ -361,8 +361,7 @@ export const LogLinkAndJSON = logPath => (
cellRender={(taskId, rowData) => (
<div className="hidden-xs">
<OverlayTrigger placement="top" id="view-log-overlay" overlay={logTooltip}>
<Link
to={`request/${taskId.requestId}/tail/${logPath}?taskIds=${taskId.id}`}
<Link to={`task/${taskId.id}/tail/${Utils.substituteTaskId(config.runningTaskLogPath, taskId.id)}`}

This comment has been minimized.

@ssalinas

ssalinas Mar 21, 2017
Member

why config.runningTaskLogPath instead of logPath here? logPath is supplied as an argument.

This comment has been minimized.

@darcatron

darcatron Mar 21, 2017
Author Contributor

my mistake, good catch. updated

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 22, 2017

👍 LGTM

@darcatron
Copy link
Contributor Author

@darcatron darcatron commented Mar 22, 2017

moved the path into a util func to prevent this issue from happening again

@darcatron darcatron added the hs_stable label Mar 22, 2017
@ssalinas ssalinas merged commit e478745 into master Mar 23, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@ssalinas ssalinas deleted the log-link-2 branch Mar 23, 2017
@ssalinas ssalinas removed hs_qa labels Mar 23, 2017
@ssalinas ssalinas modified the milestone: 0.15.0 Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.