New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing line at the bottom of logs #1472

Merged
merged 2 commits into from Apr 4, 2017

Conversation

Projects
None yet
3 participants
@PtrTeixeira
Contributor

PtrTeixeira commented Mar 27, 2017

Add a small amount of padding at the bottom of the logging container.
Now if you scroll all the way to the bottom of log tailer, there should
be a small space between the last log line and the bottom of the screen,
so that the scrollbar (on MacOS) won't overlap the last line of the
text.

Add spacing line at the bottom of logs
Add a small amount of padding at the bottom of the logging container.
Now if you scroll all the way to the bottom of log tailer, there should
be a small space between the last log line and the bottom of the screen,
so that the scrollbar (on MacOS) won't overlap the last line of the
text.
@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Mar 28, 2017

Contributor

does this work okay for multiple instances as well? just wondering since the containers stack when doing more than 3

Contributor

darcatron commented Mar 28, 2017

does this work okay for multiple instances as well? just wondering since the containers stack when doing more than 3

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 29, 2017

Member

Maybe add some screenshots for both single and multiple tail cases here?

Member

ssalinas commented Mar 29, 2017

Maybe add some screenshots for both single and multiple tail cases here?

@PtrTeixeira

This comment has been minimized.

Show comment
Hide comment
@PtrTeixeira

PtrTeixeira Mar 29, 2017

Contributor

Old:
screen shot 2017-03-29 at 9 08 58 am
screen shot 2017-03-29 at 9 33 45 am

New:
screen shot 2017-03-29 at 9 53 13 am 2
screen shot 2017-03-29 at 9 49 21 am 2

Contributor

PtrTeixeira commented Mar 29, 2017

Old:
screen shot 2017-03-29 at 9 08 58 am
screen shot 2017-03-29 at 9 33 45 am

New:
screen shot 2017-03-29 at 9 53 13 am 2
screen shot 2017-03-29 at 9 49 21 am 2

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 29, 2017

Member

I like it, LGTM 🥇

Member

ssalinas commented Mar 29, 2017

I like it, LGTM 🥇

@ssalinas ssalinas modified the milestone: 0.15.0 Mar 30, 2017

@ssalinas ssalinas merged commit 87bf686 into master Apr 4, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the add-space-to-tailer-logs branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment