Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing line at the bottom of logs #1472

Merged
merged 2 commits into from Apr 4, 2017
Merged

Conversation

@PtrTeixeira
Copy link
Contributor

PtrTeixeira commented Mar 27, 2017

Add a small amount of padding at the bottom of the logging container.
Now if you scroll all the way to the bottom of log tailer, there should
be a small space between the last log line and the bottom of the screen,
so that the scrollbar (on MacOS) won't overlap the last line of the
text.

Add a small amount of padding at the bottom of the logging container.
Now if you scroll all the way to the bottom of log tailer, there should
be a small space between the last log line and the bottom of the screen,
so that the scrollbar (on MacOS) won't overlap the last line of the
text.
@darcatron
Copy link
Contributor

darcatron commented Mar 28, 2017

does this work okay for multiple instances as well? just wondering since the containers stack when doing more than 3

@ssalinas
Copy link
Member

ssalinas commented Mar 29, 2017

Maybe add some screenshots for both single and multiple tail cases here?

@PtrTeixeira
Copy link
Contributor Author

PtrTeixeira commented Mar 29, 2017

Old:
screen shot 2017-03-29 at 9 08 58 am
screen shot 2017-03-29 at 9 33 45 am

New:
screen shot 2017-03-29 at 9 53 13 am 2
screen shot 2017-03-29 at 9 49 21 am 2

@ssalinas
Copy link
Member

ssalinas commented Mar 29, 2017

I like it, LGTM 🥇

@ssalinas ssalinas modified the milestone: 0.15.0 Mar 30, 2017
@ssalinas ssalinas added hs_qa labels Mar 30, 2017
@ssalinas ssalinas merged commit 87bf686 into master Apr 4, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@ssalinas ssalinas deleted the add-space-to-tailer-logs branch Apr 4, 2017
@ssalinas ssalinas removed hs_qa labels Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.