Reduce timeout on requests to task sandboxes #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a configurable timeout applied to the http request involved in grabbing the logs dor tailing, but not one associated with grabbing the sandbox environment for a task. This applies the same timeout the grbbing the sandbox for a task.
Drop the default timeout on HTTP requests to the sandbox from 5 seconds to 2 seconds.
|
👍 will be good to have a timeout on both in case the slave isn't responding. Most calls to read/browse seem to easily be under 500ms when working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a timeout associated with http request fetching the log files from the task sandbox, but not one associated with browsing the task's sandbox. This adds the same timeout period to browsing the sandbox. It also slightly drops the timeout period on the request, from 5 seconds to 2 seconds.