New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce timeout on requests to task sandboxes #1479

Merged
merged 2 commits into from Apr 4, 2017

Conversation

Projects
None yet
2 participants
@PtrTeixeira
Contributor

PtrTeixeira commented Mar 29, 2017

Previously there was a timeout associated with http request fetching the log files from the task sandbox, but not one associated with browsing the task's sandbox. This adds the same timeout period to browsing the sandbox. It also slightly drops the timeout period on the request, from 5 seconds to 2 seconds.

PtrTeixeira added some commits Mar 29, 2017

Apply sandbox timeout to browse endpoint
Previously there was a configurable timeout applied to the http request
involved in grabbing the logs dor tailing, but not one associated with
grabbing the sandbox environment for a task. This applies the same
timeout the grbbing the sandbox for a task.
Drop default timeout on HTTP requests for sandbox
Drop the default timeout on HTTP requests to the sandbox from 5 seconds
to 2 seconds.
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 30, 2017

Member

👍 will be good to have a timeout on both in case the slave isn't responding. Most calls to read/browse seem to easily be under 500ms when working properly.

Member

ssalinas commented Mar 30, 2017

👍 will be good to have a timeout on both in case the slave isn't responding. Most calls to read/browse seem to easily be under 500ms when working properly.

@ssalinas ssalinas modified the milestone: 0.15.0 Mar 30, 2017

@ssalinas ssalinas merged commit 5d6fea5 into master Apr 4, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the browse-sandbox-timeout branch Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment