New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better task balancing #1482

Merged
merged 73 commits into from Jun 8, 2017
Commits
Jump to file or symbol
Failed to load files and symbols.
+1 鈭1
Diff settings

Always

Just for now

Viewing a subset of changes. View all

correct weight

  • Loading branch information...
darcatron committed Mar 30, 2017
commit 6d663d6fc96d19fda377afa63105c6eda7f53ac0
@@ -295,7 +295,7 @@ private double score(SingularityOfferHolder offerHolder, SingularitySchedulerSta
private double score(Offer offer, SingularityTaskRequest taskRequest, Map<String, Map<RequestType, Map<String, Integer>>> usagesPerRequestTypePerSlave) {
double requestTypeCpuWeight = 0.20;

This comment has been minimized.

@ssalinas

ssalinas Apr 20, 2017

Member

Let's make these configurable, maybe another object in the configuration yaml?

@ssalinas

ssalinas Apr 20, 2017

Member

Let's make these configurable, maybe another object in the configuration yaml?

This comment has been minimized.

@darcatron

darcatron Apr 20, 2017

Contributor

Yup, I was in progress on this (now committed), but I kept the fields under SingularityConfiguration since I saw a lot of other stuff in there as well (e.g. caching). We could pull it into an OfferConfiguration file if you think that'd be better for organization

@darcatron

darcatron Apr 20, 2017

Contributor

Yup, I was in progress on this (now committed), but I kept the fields under SingularityConfiguration since I saw a lot of other stuff in there as well (e.g. caching). We could pull it into an OfferConfiguration file if you think that'd be better for organization

double requestTypeMemWeight = 0.20;
double requestTypeMemWeight = 0.30;
double freeCpuWeight = 0.20;
double freeMemWeight = 0.30;
double score = 0;
ProTip! Use n and p to navigate between commits in a pull request.