Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch not loaded to loading #1483

Merged
merged 2 commits into from Apr 13, 2017
Merged

switch not loaded to loading #1483

merged 2 commits into from Apr 13, 2017

Conversation

@darcatron
Copy link
Contributor

@darcatron darcatron commented Mar 31, 2017

I've found this to be confusing since it'll show 0 if it's empty or load the contents soon after. I instinctively refresh because it seems like a failure message

@ssalinas

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 31, 2017

👍 Keep in mind we'll need to bump the tailer version and publish to pull this in

@darcatron darcatron force-pushed the log-lines branch from 8441e7f to b67fb0f Apr 10, 2017
@ssalinas ssalinas merged commit ddd608d into master Apr 13, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the log-lines branch Apr 13, 2017
@ssalinas ssalinas removed hs_qa labels Apr 13, 2017
@ssalinas ssalinas modified the milestone: 0.15.0 Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.