Scale message #1487
Merged
Scale message #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Apr 6, 2017
| @@ -102,7 +102,7 @@ private void checkReschedule(SingularityRequest newRequest, Optional<Singularity | |||
| System.currentTimeMillis(), Optional.<Boolean> absent(), newRequest.getId(), Optional.of(maybeDeployId.get()), skipHealthchecks, message, actionId, maybeBounceRequest.get().getRunShellCommandBeforeKill())); | |||
|
|
|||
| if (createResult != SingularityCreateResult.EXISTED) { | |||
| requestManager.bounce(newRequest, System.currentTimeMillis(), user, Optional.of(String.format("Bouncing due to bounce after scale by %s", user))); | |||
There was a problem hiding this comment.
It's already in the user column so it seemed repetitive
ssalinas
reviewed
Apr 6, 2017
| @@ -581,6 +581,12 @@ public SingularityRequestParent scale(@ApiParam("The Request ID to scale") @Path | |||
| validator.checkScale(newRequest, Optional.<Integer>absent()); | |||
|
|
|||
| checkBadRequest(oldRequest.getInstancesSafe() != newRequest.getInstancesSafe(), "Scale request has no affect on the # of instances (%s)", newRequest.getInstancesSafe()); | |||
| String scaleMessage = String.format("Scaling from %d instance(s) to %d instances", oldRequest.getInstancesSafe(), newRequest.getInstancesSafe()); | |||
There was a problem hiding this comment.
given the size of the area it is displayed in the ui, this can probably be even shorter. i.e. from %d to %s or even %d -> %d
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the instance number change to the scale history message.
Also removed user from the bounce after scale message since the user already shows up in the user column
@ssalinas