Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when removing a request with lb configs #1499

Merged
merged 1 commit into from Apr 20, 2017
Merged

Warn when removing a request with lb configs #1499

merged 1 commit into from Apr 20, 2017

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 11, 2017

It is easy to forget when the request you are removing has associated load balancer options. Those load balancer options will stay in Baragon when the request has been paused, but will be removed if the request is removed. This will show the load balancer settings associated with the request as a warning in the removal dialog. For example:

screen shot 2017-04-10 at 9 42 57 pm

@ssalinas ssalinas added the hs_stable label Apr 19, 2017
@ssalinas ssalinas modified the milestone: 0.15.0 Apr 19, 2017
@ssalinas ssalinas merged commit a7f0ad1 into master Apr 20, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the lb_config_message branch Apr 20, 2017
@ssalinas ssalinas removed hs_qa labels Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.