Allow copying from the JSON button dialog #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the copy button on the JSON modal would not copy the text of the modal into the clipboard. This was because by default Bootstrap Modals demand focus, and clipboard js works by creating a hidden text field and copying the text out of that. The fix is allowing the modal to yield focus to the hidden text field. There was an additional performance problem that went into the problem. In particular, attaching the clipboard to a class attaches the clipboard to every modal on the page, even when the modal isn't open. Tis was fixed by starting the clipboard only when the modal is open and destroying it after the modal is closed, to prevent attaching many handlers that accumulate on the page.
|
+1 for adding the performance fix in as well 😄 LGTM |
andyhuang91
reviewed
Apr 11, 2017
|
|
||
| componentDidMount() { | ||
| this.clipboard = new Clipboard('.copy-btn'); | ||
| this.attachClipboard = this.attachClipboard.bind(this); |
There was a problem hiding this comment.
You can bind the functions in the constructor along with the showJSON and hideJSON functions. There's no reason to do this in componentDidMount. If you have lots of functions that you need to bind, you can use _.bindAll
There was a problem hiding this comment.
@andyhuang91 , it is in the constructor, if you look a bit up in the diff, you'll see he's removing the componentDidMount() { line
Slight style improvement; prefer using `_.bindAll` over many calls to `bind`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the copy button on the JSON modal would not copy the text of
the modal into the clipboard. This was because by default Bootstrap
Modals demand focus, and clipboard js works by creating a hidden text
field and copying the text out of that. The fix is allowing the modal
to yield focus to the hidden text field.
There was an additional performance problem that went into the problem.
In particular, attaching the clipboard to a class attaches the clipboard
to every modal on the page, even when the modal isn't open. Tis was
fixed by starting the clipboard only when the modal is open and
destroying it after the modal is closed, to prevent attaching many
handlers that accumulate on the page.