New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't include cleaning tasks in instance count #1505

Merged
merged 7 commits into from May 1, 2017

Conversation

Projects
None yet
2 participants
@darcatron
Contributor

darcatron commented Apr 12, 2017

Tasks that are cleaning should not be part of the instance count when checking for over provisioned requests

@ssalinas

c = new Counter();
map.put(key, c);
}
Counter c = map.computeIfAbsent(key, k -> new Counter());

This comment has been minimized.

@ssalinas

ssalinas Apr 13, 2017

Member

we are not using the key in order to determine the value here, should use putIfAbsent instead of computeIfAbsent. Same for the one below

@ssalinas

ssalinas Apr 13, 2017

Member

we are not using the key in order to determine the value here, should use putIfAbsent instead of computeIfAbsent. Same for the one below

This comment has been minimized.

@darcatron

darcatron Apr 13, 2017

Contributor

small gotcha for putIfAbsent: turns out putIfAbsent returns the old value (null) so computeIfAbsent is what we want here (returns existing or computed)
bitmoji

@darcatron

darcatron Apr 13, 2017

Contributor

small gotcha for putIfAbsent: turns out putIfAbsent returns the old value (null) so computeIfAbsent is what we want here (returns existing or computed)
bitmoji

This comment has been minimized.

@ssalinas

ssalinas Apr 13, 2017

Member

👍 good find, didn't realize that one

@ssalinas

ssalinas Apr 13, 2017

Member

👍 good find, didn't realize that one

@darcatron darcatron added the hs_qa label Apr 18, 2017

@ssalinas ssalinas modified the milestone: 0.15.0 Apr 19, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 21, 2017

Member

👍 lets get this into stable

Member

ssalinas commented Apr 21, 2017

👍 lets get this into stable

@darcatron darcatron added the hs_stable label Apr 26, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 28, 2017

Member

Just verifying the merge conflicts got resolved correctly and will merge this one too 👍

Member

ssalinas commented Apr 28, 2017

Just verifying the merge conflicts got resolved correctly and will merge this one too 👍

@ssalinas ssalinas merged commit c8b352b into master May 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the provisioned branch May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment