Include deploy marker and oldest deploy step in state #1516

Merged
merged 2 commits into from Apr 28, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Apr 26, 2017

@ssalinas ssalinas added the hs_staging label Apr 26, 2017

+ if (deployStepDelta > oldestDeployStep) {
+ oldestDeployStep = deployStepDelta;
+ }
+ }
long delta = now - pendingDeploy.getDeployMarker().getTimestamp();
if (delta > oldestDeploy) {
oldestDeploy = delta;

This comment has been minimized.

@darcatron

darcatron Apr 26, 2017

Contributor

not sure if I'm following the logic correctly here, but should this be in an else clause? Seems like we're calculating the delta twice and will get the longer time even if it's an incremental deploy

@darcatron

darcatron Apr 26, 2017

Contributor

not sure if I'm following the logic correctly here, but should this be in an else clause? Seems like we're calculating the delta twice and will get the longer time even if it's an incremental deploy

This comment has been minimized.

@ssalinas

ssalinas Apr 26, 2017

Member

two different deltas. I'm adding additional fields since it is likely some things still use the old oldestDeploy one, so still calculating that one as normal

@ssalinas

ssalinas Apr 26, 2017

Member

two different deltas. I'm adding additional fields since it is likely some things still use the old oldestDeploy one, so still calculating that one as normal

@ssalinas ssalinas merged commit 20796b3 into master Apr 28, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the oldest_deploys branch Apr 28, 2017

@ssalinas ssalinas modified the milestone: 0.15.0 Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment