Repository navigation
Spread to all slaves - #1519
Merged
Merged
Spread to all slaves#1519
Conversation
Contributor
Author
|
Additional FYI @felixgborrego , merging this in our branches to give it one last test now and I will plan to do a release of 0.15.0 monday/tuesday next week. |
Contributor
|
Thanks @ssalinas, this is going to be great to have upstream! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@felixgborrego I know this is long overdue to get this out there. Opening this PR up so I could make a few tweaks and fix some merge conflicts with our recent changes. A few things:
However, since the feature is very opt-in, I added a simple configuration flag to turn the poller and feature on or off (the validator will throw you an error if you try to use the request type when it is not enabled). With this in place I think I am comfortable to merge it in for now. You will just need to add
spreadAllSlavesEnabled: trueto your singularity yaml when starting.