Fix for request stuck in deleting state #1520

Merged
merged 2 commits into from May 8, 2017

Conversation

Projects
None yet
2 participants
@darcatron
Contributor

darcatron commented Apr 28, 2017

The main thing here is that I moved the check to re-enqueue the cleaning request outside of the if block else if (shouldKillTask(cleanupTask, activeTaskIds, cleaningTasks, incrementalCleaningTasks) && checkLBStateAndShouldKillTask(cleanupTask))

That should allow it to check if it needs to re-enqueue even if the task fails and doesn't clean up properly. Added some tests for this as well

@darcatron darcatron requested a review from ssalinas Apr 28, 2017

@ssalinas ssalinas modified the milestone: 0.16.0 May 1, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 1, 2017

Member

LGTM

Member

ssalinas commented May 1, 2017

LGTM

@darcatron darcatron merged commit 3230049 into master May 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@darcatron darcatron deleted the deleting-request branch May 8, 2017

@ssalinas ssalinas modified the milestones: 0.16.0, 0.15.1 May 8, 2017

@ssalinas ssalinas changed the title from Deleting request to Fix for request stuck in deleting state May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment