Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for request stuck in deleting state #1520

Merged
merged 2 commits into from May 8, 2017
Merged

Fix for request stuck in deleting state #1520

merged 2 commits into from May 8, 2017

Conversation

@darcatron
Copy link
Contributor

darcatron commented Apr 28, 2017

The main thing here is that I moved the check to re-enqueue the cleaning request outside of the if block else if (shouldKillTask(cleanupTask, activeTaskIds, cleaningTasks, incrementalCleaningTasks) && checkLBStateAndShouldKillTask(cleanupTask))

That should allow it to check if it needs to re-enqueue even if the task fails and doesn't clean up properly. Added some tests for this as well

@darcatron darcatron requested a review from ssalinas Apr 28, 2017
@ssalinas ssalinas modified the milestone: 0.16.0 May 1, 2017
@ssalinas
Copy link
Member

ssalinas commented May 1, 2017

LGTM

@darcatron darcatron merged commit 3230049 into master May 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@darcatron darcatron deleted the deleting-request branch May 8, 2017
@ssalinas ssalinas modified the milestones: 0.16.0, 0.15.1 May 8, 2017
@ssalinas ssalinas changed the title Deleting request Fix for request stuck in deleting state May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.