Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add skip lb removal flag to DeleteRequestRequest #1526
Add a flag that can be set on the request deletion request to avoid
Add a flag that can be set on the request deletion request to avoid removing the basepath associated with the service from the load balancer. The suggested use case is when the application associated with the service is moving out of Singularity, but will still be running and should remain load-balanced.
When a request has active tasks, first the tasks are removed and the request cleanup request is destroyed. Once all the tasks are removed, then a new request cleanup request is submitted. I had missed this case, so the `removeFromLoadBalancer` flag was set on the first request, but not on the second, when it would actually take affect. This correctly propagates the `removeFromLoadBalancer` flag across both requests.