Repository navigation
Conversation
|
Thanks @ssalinas. The test cleanup is nice, but it's a disappointing the injection is now a little more cumbersome. I wonder if this is actually intended given the jersey/dropwizard upgrade, or if it's an upstream bug. |
Contributor
Author
|
@pennello , as far as I could tell it was never really documented that an |
Contributor
|
Yeah, I'll second the surprise that the container doesn't do this for you (maybe there's a fix that should go upstream to Jersey?) but obviously I'm in favor of fixing the issue despite uglifying the code :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that after the jersey/dropwizard upgrade the Optional bodies are not coming through correctly and are
nullinstead ofabsent()when the body is not present. Updated the impacted endpoints (anything with anOptionalbody) to take the object (nullable) and construct theOptionalafterwards. Actually made the tests look a bit nicer not wrapping everything inOptional.of()too.I can test this out and try to get a 15.1 out if it looks good.
/cc @darcatron @stevenschlansker @dstryker @pennello @sannessa
/fixes #1525