Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow immediate run in pending queue with deploy #1538
Give immediate run requests in the pending queue a separate key, so they
Give immediate run requests in the pending queue a seperate key, so they are permitted to be in the pending queue at the same time as a new deploy for the same requestID / deployID. This means that a pending deploy will not block an immediate run from being enqueued.
Defer checking duplicate requests from ZK into the scheduler. This allows slightly more control over what kinds of requests are allowed to be in the pending queue simultaneously, and avoids the kind of edge cases that we were running into previously by attempting to use nodenames in ZK to resolve the same problem. /cc @ssalinas
In particular - Revert to only using the timestamp format for immediate & one-off requests - Correct the order of schedule / delete in the scheduler to guarantee that the scheduler is not left in an inconsistent state. - Rename some variables for consistency with the result of the class