Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefuse to add cleaning tasks to LB #1554
Merged
Conversation
|
/cc @ssalinas |
Prior to adding a load-balanced task to the load balancer, check that - there is no existing LB state - If there is an existing LB state: - It is still unknown to Baragon - We aren't already tring to remove it from Baragon
|
Looks good with the additional check for unknown + != REMOVE, let's give this a go in staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PtrTeixeira commentedMay 30, 2017
Refuse to add tasks which are in the cleaning state the the load
balancer. This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.