Refuse to add cleaning tasks to LB - #1554
Merged
Merged
Conversation
Refuse to add tasks which are in the cleaning state the the load balancer. This is a slightly ham-handed way to prevent inconsistencies, like where a task us removed from the load balancer due to the cleaning process before ever being added to the load balancer.
Contributor
Author
|
/cc @ssalinas |
Prior to adding a load-balanced task to the load balancer, check that - there is no existing LB state - If there is an existing LB state: - It is still unknown to Baragon - We aren't already tring to remove it from Baragon
ssalinas
approved these changes
Jun 1, 2017
ssalinas
left a comment
ssalinas
left a comment
Contributor
There was a problem hiding this comment.
Looks good with the additional check for unknown + != REMOVE, let's give this a go in staging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refuse to add tasks which are in the cleaning state the the load
balancer. This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.