Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse to add cleaning tasks to LB #1554

Merged
merged 3 commits into from Jun 8, 2017
Merged

Refuse to add cleaning tasks to LB #1554

merged 3 commits into from Jun 8, 2017

Conversation

PtrTeixeira
Copy link
Contributor

Refuse to add tasks which are in the cleaning state the the load
balancer. This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.

Refuse to add tasks which are in the cleaning state the the load
balancer.  This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.
@PtrTeixeira
Copy link
Contributor Author

/cc @ssalinas

Prior to adding a load-balanced task to the load balancer, check that
- there is no existing LB state
- If there is an existing LB state:
  - It is still unknown to Baragon
  - We aren't already tring to remove it from Baragon
Copy link
Member

@ssalinas ssalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the additional check for unknown + != REMOVE, let's give this a go in staging

@ssalinas ssalinas modified the milestone: 0.16.0 Jun 2, 2017
@ssalinas ssalinas merged commit d1a84a2 into master Jun 8, 2017
@ssalinas ssalinas deleted the lb-cleanup-order branch June 8, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants