New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse to add cleaning tasks to LB #1554

Merged
merged 3 commits into from Jun 8, 2017

Conversation

Projects
None yet
2 participants
@PtrTeixeira
Contributor

PtrTeixeira commented May 30, 2017

Refuse to add tasks which are in the cleaning state the the load
balancer. This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.

PtrTeixeira added some commits May 30, 2017

Refuse to add cleaning tasks to LB
Refuse to add tasks which are in the cleaning state the the load
balancer.  This is a slightly ham-handed way to prevent inconsistencies,
like where a task us removed from the load balancer due to the cleaning
process before ever being added to the load balancer.
@PtrTeixeira

This comment has been minimized.

Show comment
Hide comment
Contributor

PtrTeixeira commented May 30, 2017

/cc @ssalinas

Check that we are not removing the request for add
Prior to adding a load-balanced task to the load balancer, check that
- there is no existing LB state
- If there is an existing LB state:
  - It is still unknown to Baragon
  - We aren't already tring to remove it from Baragon
@ssalinas

Looks good with the additional check for unknown + != REMOVE, let's give this a go in staging

@ssalinas ssalinas modified the milestone: 0.16.0 Jun 2, 2017

@PtrTeixeira PtrTeixeira added the hs_qa label Jun 5, 2017

@ssalinas ssalinas added the hs_stable label Jun 6, 2017

@ssalinas ssalinas merged commit d1a84a2 into master Jun 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the lb-cleanup-order branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment