Better bash escaping in docker runner script #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
force-pushed
the
shell_quote
branch
2 times, most recently
from
f27c19e
to
4a5c6d6
Compare
ssalinas
force-pushed
the
shell_quote
branch
2 times, most recently
from
ce600da
to
3340832
Compare
bug fixing handle the new lines don't miss port options more escaping in env allow non-backtick vars to be evaluated fix import second usage of helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Still need to test this one out a bit more, but this should generally help the escaping issues in the command section
FYI @jonathanwgoodwin