New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better bash escaping in docker runner script #1568

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jun 16, 2017

Still need to test this one out a bit more, but this should generally help the escaping issues in the command section

FYI @jonathanwgoodwin

Better bash escaping in docker runner script
bug fixing

handle the new lines

don't miss port options

more escaping in env

allow non-backtick vars to be evaluated

fix import

second usage of helper

@ssalinas ssalinas modified the milestone: 0.16.0 Jun 23, 2017

@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Jun 26, 2017

Contributor

🚢

Contributor

darcatron commented on c4e6c68 Jun 26, 2017

🚢

@ssalinas ssalinas added the hs_stable label Jun 26, 2017

@ssalinas ssalinas merged commit 946d808 into master Jun 27, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the shell_quote branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment