Skip to content

Better bash escaping in docker runner script #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Better bash escaping in docker runner script #1568

merged 1 commit into from
Jun 27, 2017

Conversation

ssalinas
Copy link
Member

Still need to test this one out a bit more, but this should generally help the escaping issues in the command section

FYI @jonathanwgoodwin

@ssalinas ssalinas force-pushed the shell_quote branch 2 times, most recently from f27c19e to 4a5c6d6 Compare June 19, 2017 15:55
@ssalinas ssalinas added the hs_qa label Jun 19, 2017
@ssalinas ssalinas force-pushed the shell_quote branch 2 times, most recently from ce600da to 3340832 Compare June 20, 2017 15:04
bug fixing

handle the new lines

don't miss port options

more escaping in env

allow non-backtick vars to be evaluated

fix import

second usage of helper
@ssalinas ssalinas modified the milestone: 0.16.0 Jun 23, 2017
@ssalinas ssalinas merged commit 946d808 into master Jun 27, 2017
@ssalinas ssalinas deleted the shell_quote branch June 27, 2017 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants