Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better bash escaping in docker runner script #1568

Merged
merged 1 commit into from Jun 27, 2017
Merged

Better bash escaping in docker runner script #1568

merged 1 commit into from Jun 27, 2017

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jun 16, 2017

Still need to test this one out a bit more, but this should generally help the escaping issues in the command section

FYI @jonathanwgoodwin

@ssalinas ssalinas force-pushed the shell_quote branch from d19e03e to db0f388 Jun 16, 2017
@ssalinas ssalinas added the hs_staging label Jun 19, 2017
@ssalinas ssalinas force-pushed the shell_quote branch 2 times, most recently from f27c19e to 4a5c6d6 Jun 19, 2017
@ssalinas ssalinas added the hs_qa label Jun 19, 2017
@ssalinas ssalinas force-pushed the shell_quote branch 2 times, most recently from ce600da to 3340832 Jun 20, 2017
bug fixing

handle the new lines

don't miss port options

more escaping in env

allow non-backtick vars to be evaluated

fix import

second usage of helper
@ssalinas ssalinas force-pushed the shell_quote branch from 3340832 to c4e6c68 Jun 20, 2017
@ssalinas ssalinas modified the milestone: 0.16.0 Jun 23, 2017
@darcatron

This comment has been minimized.

Copy link
Contributor

@darcatron darcatron commented on c4e6c68 Jun 26, 2017

🚢

@ssalinas ssalinas added the hs_stable label Jun 26, 2017
@ssalinas ssalinas merged commit 946d808 into master Jun 27, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the shell_quote branch Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.