New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource usage endpoint #1570

Merged
merged 35 commits into from Jul 14, 2017

Conversation

Projects
None yet
4 participants
@darcatron
Contributor

darcatron commented Jun 20, 2017

  • add some unit tests

Added endpoint to get resource usage data for each tracked request and the cluster as a whole.
Increased the number of points collected form 5 -> 15 and increased the interval between each point (poll frequency x interval) so we have a wider span of data

@darcatron darcatron requested a review from ssalinas Jun 20, 2017

@PtrTeixeira

I don't know whether this has anything to do with your changes, and is probably just because those tests were fragile to start off with, but it looks like the tests SingularityMesosSchedulerTest (these aren't a big problem; these look like a problem with double comparisons) and Whitney's old tests in SingularityUsageTest have started breaking.

@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Jun 22, 2017

Contributor

@PtrTeixeira I've fixed some of those tests locally already and am working on getting mine written and the others fixed as well

Contributor

darcatron commented Jun 22, 2017

@PtrTeixeira I've fixed some of those tests locally already and am working on getting mine written and the others fixed as well

@ssalinas ssalinas modified the milestone: 0.17.0 Jun 23, 2017

@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Jul 13, 2017

Contributor

@ssalinas looking good in qa. okay to get it into prod?

Contributor

darcatron commented Jul 13, 2017

@ssalinas looking good in qa. okay to get it into prod?

@darcatron darcatron added the hs_stable label Jul 13, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 14, 2017

Member

Going to merge this one. Any further updates can be done in future PRs

Member

ssalinas commented Jul 14, 2017

Going to merge this one. Any further updates can be done in future PRs

@ssalinas ssalinas merged commit 2b00479 into master Jul 14, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the use-it-or-lose-it branch Jul 14, 2017

@baconmania baconmania modified the milestones: 0.18.0, 0.17.0 Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment