New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when 'maxTotalHealthcheckTimeout' set #1572

Merged
merged 2 commits into from Jun 28, 2017

Conversation

Projects
None yet
2 participants
@PtrTeixeira
Contributor

PtrTeixeira commented Jun 21, 2017

The comparison was flipped in the validator the max total health check
timeout seconds, where when it was set it would reject anything less
than that period, rather than anything greater than it. We never noticed
the bug because internally this isn't a field that we set.

/cc @ssalinas

Fix bug when 'maxTotalHealthcheckTimeout' set
The comparison was flipped in the validator the max total healtheck
timeout seconds, where when it was set it would reject anything _less_
than that period, rather than anything greater than it. We never noticed
the bug because internally this isn't a field that we set.
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jun 22, 2017

Member

👍 another that can go to staging

Member

ssalinas commented Jun 22, 2017

👍 another that can go to staging

@ssalinas ssalinas modified the milestone: 0.16.0 Jun 23, 2017

@ssalinas ssalinas added hs_qa and removed hs_qa labels Jun 27, 2017

@ssalinas ssalinas merged commit c414433 into master Jun 28, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the singularity-validator-bug branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment