Evenly-spread task placement - #1576
Merged
Merged
Conversation
ssalinas
reviewed
Jul 5, 2017
| @@ -333,7 +333,8 @@ public void testFrozenSlaveCanBeDecommissioned() { | |||
|
|
|||
| saveAndSchedule(request.toBuilder().setSlavePlacement(Optional.of(SlavePlacement.OPTIMISTIC)).setInstances(Optional.of(2))); | |||
Contributor
There was a problem hiding this comment.
feel free to change this to GREEDY or SEPARATE so that the frozen slave test isn't relying on calculations from optimistic
ssalinas
reviewed
Jul 5, 2017
|
|
||
| final boolean isSlaveOk = numOnSlave < numPerSlave; | ||
| // If no tasks are active for this request yet, we can fall back to greedy. | ||
| if (currentlyActiveTasksForRequestClusterwide.size() > 0) { |
Contributor
There was a problem hiding this comment.
would it make sense to make this more explicit with a == 0 check + early return rather than having to add a comment?
Contributor
Author
There was a problem hiding this comment.
Hmm, so the general pattern in this method is to return only if the SlaveMatchState is determined to be something other than OK. Otherwise, flow is allowed to trickle down to that final return SlaveMatchState.OK statement.
ssalinas
reviewed
Jul 5, 2017
| final boolean isSlaveOk = numOnSlave <= numPerSlave; | ||
|
|
||
| if (!isSlaveOk) { | ||
| LOG.trace("Rejecting OPTIMISTIC task {} from slave {} ({}) due to numOnSlave {}", taskRequest.getRequest().getId(), slaveId, host, numOnSlave); |
Contributor
There was a problem hiding this comment.
might want to add the other values you're using in he calculation in here for debugging purposes
…lacement strategy logic for this test.
baconmania
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.