Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor tailer instance selection dropdown #1586
The instance select dropdown has been refactored into a class and to use react-bootstrap components.
This also fixes two issues:
Nice, looks pretty smooth in staging. Isn't an easy way to get around the re-render when going to/from 1 instance. Not worried about that one for now.
Only question is around the limit on selecting. I think the tailer limits to no more than six instances tailed at once, are we enforcing that in any way when clicking select all? (i.e. selects only the first 6 or something?)
There doesn't appear to be anything stopping me from tailing more than 6 instances in the current implementation. I know it's not very useful from a readability/performance standpoint though.
However it could be more confusing on the user's end to get capped at a seemingly arbitrary number (think about those ultrawide early adopters!). Also if all Select All does is toggle the first six instances I think it loses much of it's usefulness.