New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tailer instance selection dropdown #1586
Conversation
Nice, looks pretty smooth in staging. Isn't an easy way to get around the re-render when going to/from 1 instance. Not worried about that one for now. Only question is around the limit on selecting. I think the tailer limits to no more than six instances tailed at once, are we enforcing that in any way when clicking select all? (i.e. selects only the first 6 or something?) |
There doesn't appear to be anything stopping me from tailing more than 6 instances in the current implementation. I know it's not very useful from a readability/performance standpoint though. However it could be more confusing on the user's end to get capped at a seemingly arbitrary number (think about those ultrawide early adopters!). Also if all Select All does is toggle the first six instances I think it loses much of it's usefulness. |
Fair enough on usability. Mostly don't want to crash anyones browser from accidentally trying to tail 30 instances or something. |
True. How about we take a middle ground and cap it at the first 8 instances when selecting all? I'm able to open that many without any immediate performance issues in my browser. |
Sounds like a plan 👍 |
The instance select dropdown has been refactored into a class and to use react-bootstrap components.
This also fixes two issues:
Caveats: