Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key error on requests page #1587

Merged
merged 1 commit into from Jul 14, 2017
Merged

Fix key error on requests page #1587

merged 1 commit into from Jul 14, 2017

Conversation

kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Jul 11, 2017

Removes an unnecessary <div> around FormModal.INPUT_TYPES.MULTIINPUT to stop React complaining about the key attribute missing at the top level.

@kwm4385 kwm4385 added the UI label Jul 11, 2017
@kwm4385 kwm4385 self-assigned this Jul 11, 2017
@kwm4385 kwm4385 requested a review from ssalinas July 11, 2017 18:45
@ssalinas
Copy link
Member

👍 , must have previously been multiple elements there to necessitate the div or something

@kwm4385 kwm4385 added the hs_qa label Jul 12, 2017
@ssalinas ssalinas modified the milestone: 0.17.0 Jul 14, 2017
@ssalinas ssalinas merged commit 84019de into master Jul 14, 2017
@ssalinas ssalinas deleted the fix-key-error branch July 14, 2017 19:41
@baconmania baconmania modified the milestones: 0.18.0, 0.17.0 Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssalinas ssalinas ssalinas approved these changes

Assignees

@kwm4385 kwm4385

Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwm4385 @ssalinas @baconmania