New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flaky tests #1593

Merged
merged 8 commits into from Jul 24, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jul 14, 2017

slowly combating things that break the travis build...

Changed these over to use conditions with timeouts so the build will still pass on a system where it may take more than the previous 50ms pause to get things going.

@ssalinas ssalinas added the hs_staging label Jul 14, 2017

@ssalinas ssalinas added this to the 0.17.0 milestone Jul 14, 2017

ssalinas added some commits Jul 14, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jul 17, 2017

Member

FYI @darcatron @baconmania I've added a hard time limit of 30 seconds on all tests. This should help us weed out the one test that is occasionally hanging (think it is health check related) as well as forcing us to clean up the test framework if things get too slow 😉

Member

ssalinas commented Jul 17, 2017

FYI @darcatron @baconmania I've added a hard time limit of 30 seconds on all tests. This should help us weed out the one test that is occasionally hanging (think it is health check related) as well as forcing us to clean up the test framework if things get too slow 😉

@ssalinas ssalinas added the hs_qa label Jul 17, 2017

@ssalinas ssalinas added the hs_stable label Jul 17, 2017

@ssalinas ssalinas merged commit 23f082b into master Jul 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the more_flaky_tests branch Jul 24, 2017

@baconmania baconmania modified the milestones: 0.18.0, 0.17.0 Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment